FpML Issues Tracker
closed
Major
Always
Validation Rules
Admin
lyteck
Summary
Two conflicting definitions of the precondition context are given.
http://www.fpml.org/spec/fpml-4-4-5-lcwd-1/html/index.html
"Preconditions
The Validation Preconditions only apply when specific rules reference them. The following preconditions are always to be executed relative to the root of the FpML document being validated. The context of the rule is NOT carried through to the precondition.
Precondition: SameCurrency All instances of currency values within the context of this rule must be identical."
Problem 1: The precondition cannot know about the context of "this rule". Either the precondition has document context, or it has the rules context, or it has a third context, but it can't have more than one.
Problem 2: In a portfolio of trades the precondition doesn't make sense as a global document context. It would apply to more than one trade/product at a time.
Problem 3: The precondition ignores currency schemes. If the schemes vary but the currency doesn't, etc.
Notes:
mgratacos
04/23/08 3:15 pm
Minutes EQDWG 2008-04-23:
Accept proposed resolution for issue #666
mgratacos
04/23/08 3:16 pm
I think that the implementation using functions should be reviewed by the Validation Working Group.
matthewdr
04/29/08 1:44 pm
Discussed at VWG. Agreed that if AJ can define a counter-proposal we will discuss, otherwise the VWG will accept the EQDWG’s proposal.
mgratacos
04/29/08 1:45 pm
April 29, 2008: Agreement to ask for counterproposals, otherwise we’ll accept Matthew’s proposal.
matthewdr
05/02/08 4:40 pm
This also solves the problem that CD and EQD have the same predondition defined with the same name, and it is impossible to distinguish them.
Both CD and EQD have “sameCurrency” as a precondition.
lyteck
08/26/08 5:58 pm
SameCurrency condition removed in EQD and CD
superceded by function same-currency() in:
– eqd-19, eqd-20, eqd-25
– cd-37
matthewdr
08/27/08 12:30 pm
The SameCurrency condition must be removed from the CD definition. It is still present.
”
Condition: SameCurrency
Every element of type Money should have the same currency.
”
matthewdr
08/27/08 12:31 pm
Assigned to Lyteck to remove the SameCurrency condition from the CD rules.
lyteck
08/27/08 1:06 pm
removed.
matthewdr
08/27/08 2:07 pm
Accepting after review.