FpML Issues Tracker

1102: shared-10 and shared-22 test the same thing

April 1, 2012

closed

Minor

Always

Validation Rules

Admin

danieldui

Summary

Shared-22 appears to test exactly the same thing as shared-10.

Compare ..

shared-10 (Mandatory) English Description: Context: CalculationAgent (complex type) The values of calculationAgentPartyReference/@href attributes shall be unique. XPath Description: Context: CalculationAgent count(distinct-values(calculationAgentPartyReference/@href)) eq count(calculationAgentPartyReference/@href) Comment: It does not make sense for a party to be listed more than once as calculation agent to a trade.

With ..

shared-22 (Mandatory) English Description: Context: CalculationAgent (complex type) Each calculationAgentPartyReference/@href must be unique Comment: Each party needs only be referenced once as a calculation agent. Test cases: [Invalid]

Remove rule shared-22

Notes:

  • danieldui

    06/12/12 11:20 am

    That seems to be the case. I agree to remove shared-22.

    Does anyone in the group recall how/why we ended up with a duplicate rule?

  • danieldui

    06/12/12 3:02 pm

    ACTION: Irina to check where rule Shared-10 and Shared-22 came and what might have caused the duplication. Irina thinks it’s probably a mistake made during a re factoring exercise that happened some time ago.

  • mkoli

    06/26/12 1:54 pm

    removed shared-22

  • mkoli

    06/26/12 1:56 pm

    Rule Shared-22 was a duplicate of Shared-10.
    Shared-22 has been removed.
    Changed have been checked in rules-english-shared.xml

    • Leave an update

    You must be logged in to post an update.

    Report an Issue

    The FpML Issues Tracker is designed to facilitate public interaction in the standard.

    By registering you will be able to submit corrections and comments, generate reports, and view the complete issues archive for FpML.

    Report Issue